Re: [Xen-devel] [OSSTEST Nested PATCH v11 4/7] Changes on test step of Debian hvm guest install

["Pang, LongtaoX" <longtaox.pang@xxxxxxxxx>]

> -----Original Message-----
> From: Ian Campbell [mailto:ian.campbell@xxxxxxxxxx]
> Sent: Tuesday, June 09, 2015 4:08 PM
> To: Pang, LongtaoX
> Cc: xen-devel@xxxxxxxxxxxxx; Ian.Jackson@xxxxxxxxxxxxx; wei.liu2@xxxxxxxxxx; 
> Hu,
> Robert
> Subject: Re: [OSSTEST Nested PATCH v11 4/7] Changes on test step of Debian hvm
> guest install
> 
> On Tue, 2015-06-09 at 05:29 +0000, Pang, LongtaoX wrote:
> >
> >
> > > -----Original Message-----
> > > From: Ian Campbell [mailto:ian.campbell@xxxxxxxxxx]
> > > Sent: Monday, June 08, 2015 6:31 PM
> > > To: Pang, LongtaoX
> > > Cc: xen-devel@xxxxxxxxxxxxx; Ian.Jackson@xxxxxxxxxxxxx; 
> > > wei.liu2@xxxxxxxxxx;
> Hu,
> > > Robert
> > > Subject: Re: [OSSTEST Nested PATCH v11 4/7] Changes on test step of Debian
> hvm
> > > guest install
> > >
> > > On Tue, 2015-05-26 at 17:08 +0800, longtao.pang wrote:
> > > > 1. The default disk size for guest is '10000M' which is not sufficient
> > > > for nested HVM guest, using larger disk size for nested guest
> > > > to accommodate to nested test requirement, the specific disk_size is
> > > > defined by make-flight.
> > > > 2. In L1 installation context, assign more memory (defined in runvar) to
> > > > it; Since it acts as a nested hypervisor anyway.
> > > > 3. Comment out CDROM entry in sources.list to make HTTP URL entry
> > > > available for L1 hvm guest.
> > > > 4. Enable nestedhvm feature in 'ExtraConfig' for nested job.
> > > >
> > > > Signed-off-by: longtao.pang <longtaox.pang@xxxxxxxxx>
> > >
> > > Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > >
> > > One query:
> > > [...]
> > > > @@ -174,13 +185,18 @@ sub prep () {
> > > >      if ($host_freemem_mb > $ram_lots * 2 + $ram_minslop) {
> > > >          $ram_mb = $ram_lots;
> > > >      } else {
> > > > -        $ram_mb = 768;
> > > > +        # Use guest_var to get specific memsize, or will use default 
> > > > '768'
> > > > +        $ram_mb= guest_var($gho,'memsize',768);
> > >
> > > I think this only happens if the host has less than "$ram_lots * 2 +
> > > $ram_minslop" (==10100M) free, otherwise you get $ram_lots (5000M),
> > > which might be less than the runvar asked for...
> > >
> > For nested job, the specific 'memsize' for L1 guest is 3072M which is 
> > defined by
> make-flight.
> > If the "$ram_lots" equal to 5000M which is larger than 3072M, that's 
> > suitable
> for nested L1 guest.
> > The condition for nested L1 guest's memory size that should not be less than
> 3072M, that's why we
> > add the code of "$ram_mb =guest_var($gho,'memsize',768)" here.
> 
> I was talking about the general case, which is broken for any guest
> configured to have RAM > $ram_lots.
> 
Thanks Ian, I get your point now. 
> 
> > > Perhaps what we really want (maybe in a followup patch is):
> > >
> > >         $ram_mb = guest_var($gho,'memsize',undef);
> > >         if (!$ram_mb) {
> > >              if ($host_freemem_mb > $ram_lots * 2 + $ram_minslop) {
> > >                   $ram_mb = $ram_lots;
> > >              } else {
> > >                   $ram_mb = 768;
> > >              }
> > >         }
> > > ?
> > >
> > So, I think maybe it's no need to change that.
> > Please correct me, if I am wrong.
> 
Yes, your above patch is more suitable here and it's necessary to change the 
code.
Could you please change this query in your branch, so that I will not summit 
another version of nested patch to you?
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel