[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v2 27/41] arm : add helper functions to map memory regions
- To: Parth Dixit <parth.dixit@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxx>
- From: Julien Grall <julien.grall@xxxxxxxxxx>
- Date: Mon, 8 Jun 2015 15:05:56 +0100
- Cc: keir@xxxxxxx, ian.campbell@xxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, tim@xxxxxxx, julien.grall@xxxxxxxxxx, stefano.stabellini@xxxxxxxxxx, jbeulich@xxxxxxxx, christoffer.dall@xxxxxxxxxx
- Delivery-date: Mon, 08 Jun 2015 23:01:27 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
Hi Parth,
On 17/05/2015 21:03, Parth Dixit wrote:
creates a helper function for mapping with cached attributes
Signed-off-by: Parth Dixit <parth.dixit@xxxxxxxxxx>
---
xen/arch/arm/p2m.c | 26 ++++++++++++++++++++++++++
xen/include/asm-arm/p2m.h | 10 ++++++++++
2 files changed, 36 insertions(+)
diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index 903fa3f..fcb8116 100644
--- a/xen/arch/arm/p2m.c
+++ b/xen/arch/arm/p2m.c
@@ -1140,6 +1140,32 @@ int p2m_populate_ram(struct domain *d,
d->arch.p2m.default_access);
}
+int map_regions(struct domain *d,
+ unsigned long start_gfn,
+ unsigned long nr,
+ unsigned long mfn)
The name doesn't match the behavior. How the user will know that
map_regions is actually using cached attribute.
Also, I would prefer a function taking the caching attribute in
parameter. I would be more generic that trying to introduce a new
function every time is a new attribute is required.
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|
