Re: [Xen-devel] [PATCH v3 1/2] net/xen-netfront: Correct printf format in xennet_get_responses

[David Miller <davem@xxxxxxxxxxxxx>]

From: Julien Grall <julien.grall@xxxxxxxxxx>
Date: Thu, 4 Jun 2015 16:35:13 +0100

> rx->status is an int16_t, print it using %d rather than %u in order to
> have a meaningful value when the field is negative.
> 
> Also use %d rather than %x for rx->offset.
> 
> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> Reviewed-by: David Vrabel <david.vrabel@xxxxxxxxxx>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> Cc: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
> Cc: netdev@xxxxxxxxxxxxxxx
> 
> ---
>     Changes in v3:
>         - Use %d for the rx-offset too.

This change in v3 is wrong, 'rx->offset' is unsigned therefore %u is
the correct format string to use.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel