Re: [Xen-devel] [RFC 11/22] xen/arm: gic-hip04: Remove redundant check in hip04gic_init

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 05/06/15 13:26, Ian Campbell wrote:
> On Fri, 2015-06-05 at 13:24 +0100, Ian Campbell wrote:
>> On Fri, 2015-05-08 at 14:29 +0100, Julien Grall wrote:
>>> There is a global check for page alignment within this function.
>>>
>>> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
>>> Cc: Zoltan Kiss <zoltan.kiss@xxxxxxxxxx>
>>
>> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
> Lets make that a blanket Ack for any gic-hop04 patch in this series
> where I've already acked a basically equivalent gicv2 patch.
> 
> In fact for the scope of these changes:
>   xen/arm: *: Remove redundant check in gicv2_init
>   xen/arm: *: Use SZ_64K rather than our custom value
>   xen/arm: *: Use SZ_4K rather than PAGE_SIZE
>   xen/arm: *: Allow the base address to be 0
> 
> it would be fine to just do them in one "Use SZ_64K in all gic drivers"
> type patch.

It was easier for me to keep track of the changes made in different
driver. Shall I merge them in the next version?

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel