Re: [Xen-devel] [PATCH v11 3/9] tools: Add vmware_hwver support

[Don Slutz <dslutz@xxxxxxxxxxx>]

On 06/04/15 11:15, Ian Campbell wrote:
> On Wed, 2015-06-03 at 15:53 +0100, George Dunlap wrote:
>> On 05/22/2015 04:50 PM, Don Slutz wrote:
>>> This is used to set xen_arch_domainconfig vmware_hw. It is set to
>>> the emulated VMware virtual hardware version.
>>>
>>> Currently 0, 3-4, 6-11 are good values.  However the code only
>>> checks for == 0, != 0, or < 7.
>>>
>>> Signed-off-by: Don Slutz <dslutz@xxxxxxxxxxx>
>>
>> Ian,
>>
>> It looks like you gave a pre-approved Ack to something almost identical
>> to v10.
> 
> In v9 I indicated that LIBXL_HAVE_LIBXL_VGA_INTERFACE_TYPE_VMWARE and
> LIBXL_HAVE_BUILDINFO_HVM_VMWARE_HWVER could be covered by a single ack
> (introducing vmware support generally).
> 
> In v11 this seems to have morphed into only
> LIBXL_HAVE_LIBXL_VGA_INTERFACE_TYPE_VMWARE being provided, which is
> clearly not an appropriate umbrella #define.
> 

Only in PATCH 1/9 -- Which in v11 is now completely independent.  I only
kept it in the series since in v10 it was not fully independent.

> I'm also not sure if there is more stuff later in the series, if so then
> unless it is all committed together an umbrella option may not work,
> unless it is added right at the end, in which case I suppose having some
> "unadvertised" functionality in the midst of a dev cycle would be ok.
> Releasing like that would be a mistake though.
> 

There is one later in the series 7/9.  to which you said (in a different
thread):

>> +#define LIBXL_HAVE_CREATEINFO_VMWARE 1
>
> Lets just have a single one of these indicating support for vmware, it
> should be added at the end of the series after all the baseline vmware
> functionality is in place. I think that means hwver, vga=vmware and this
> port stuff.
>
> (Future incremental changes will of course require their own flags).

If I am reading this correctly, you want PATCH 1/9 to not be completely
independent.

   -Don Slutz

> Ian.
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel