Re: [Xen-devel] [PATCH V9] xen/vm_event: Clean up control-register-write vm_events and add XCR0 event

["Lengyel, Tamas" <tlengyel@xxxxxxxxxxx>]

diff --git a/xen/include/asm-x86/domain.h b/xen/include/asm-x86/domain.h
index 45b5283..a3c117f 100644
--- a/xen/include/asm-x86/domain.h
+++ b/xen/include/asm-x86/domain.h
@@ -341,15 +341,9 @@ struct arch_domain

  Â/* Monitor options */
  Âstruct {
-    uint16_t mov_to_cr0_enabled     : 1;
-    uint16_t mov_to_cr0_sync      Â: 1;
-    uint16_t mov_to_cr0_onchangeonly  Â: 1;
-    uint16_t mov_to_cr3_enabled     : 1;
-    uint16_t mov_to_cr3_sync      Â: 1;
-    uint16_t mov_to_cr3_onchangeonly  Â: 1;
-    uint16_t mov_to_cr4_enabled     : 1;
-    uint16_t mov_to_cr4_sync      Â: 1;
-    uint16_t mov_to_cr4_onchangeonly  Â: 1;
+    uint16_t write_ctrlreg_enabled   Â: 4;
+    uint16_t write_ctrlreg_sync     : 4;
+    uint16_t write_ctrlreg_onchangeonly : 4;

Just looking at this here again, we will now have a bitmap within a bitmap, which doesn't seem to be very efficient. IMHO it would be better to just take the ctrlreg bitmap out as a separate uint8_t within struct {} monitor.

Â

    Âuint16_t mov_to_msr_enabled     : 1;
    Âuint16_t mov_to_msr_extended    Â: 1;
    Âuint16_t singlestep_enabled     : 1;

--

Tamas K Lengyel

Senior Security Researcher

7921 Jones Branch Drive

McLean VA 22102

Email Âtlengyel@novetta.com

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel