Re: [Xen-devel] [PATCH v7 09/10] libxc: add XC_DEVICE_MODEL_SAVE_FILE

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2015-05-27 at 17:25 +0200, Vitaly Kuznetsov wrote:
> Use this in libxl_dm instead of hard-coding.
> 
> Signed-off-by: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>

This is something of an artefact of the layering weirdness regarding the
DM save/restore (saved by libxl, restored by libxc), but I think there
is no harm having this #define in libxc alongside the other one even if
it is actually (currently) handled by libxl.

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> ---
>  tools/libxc/include/xenguest.h | 1 +
>  tools/libxl/libxl_dm.c         | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/libxc/include/xenguest.h b/tools/libxc/include/xenguest.h
> index c71b423..98b3a37 100644
> --- a/tools/libxc/include/xenguest.h
> +++ b/tools/libxc/include/xenguest.h
> @@ -168,6 +168,7 @@ int xc_soft_reset(xc_interface *xch, uint32_t source_dom,
>                 unsigned long *console_mfn, domid_t store_domid,
>                 unsigned long *store_mfn);
>  
> +#define XC_DEVICE_MODEL_SAVE_FILE "/var/lib/xen/qemu-save"
>  #define XC_DEVICE_MODEL_RESTORE_FILE "/var/lib/xen/qemu-resume"
>  
>  /**
> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
> index 0c6408d..869f4cd 100644
> --- a/tools/libxl/libxl_dm.c
> +++ b/tools/libxl/libxl_dm.c
> @@ -31,7 +31,7 @@ static const char *libxl_tapif_script(libxl__gc *gc)
>  
>  const char *libxl__device_model_savefile(libxl__gc *gc, uint32_t domid)
>  {
> -    return libxl__sprintf(gc, "/var/lib/xen/qemu-save.%d", domid);
> +    return libxl__sprintf(gc, XC_DEVICE_MODEL_SAVE_FILE".%d", domid);
>  }
>  
>  static const char *qemu_xen_path(libxl__gc *gc)



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel