Re: [Xen-devel] [PATCH] libxl: Don't insert PCI device into xenstore for HVM guests

[George Dunlap <George.Dunlap@xxxxxxxxxxxxx>]

On Fri, May 29, 2015 at 8:59 AM, Ross Lagerwall
<ross.lagerwall@xxxxxxxxxx> wrote:
> When doing passthrough of a PCI device for an HVM guest, don't insert
> the device into xenstore, otherwise pciback attempts to use it which
> conflicts with QEMU.
>
> This manifests itself such that the first time a device is passed to a
> domain, it succeeds. Subsequent attempts fail unless the device is
> unbound from pciback or the machine rebooted.
>
> Signed-off-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
> ---
>  tools/libxl/libxl_pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/libxl/libxl_pci.c b/tools/libxl/libxl_pci.c
> index e0743f8..2552889 100644
> --- a/tools/libxl/libxl_pci.c
> +++ b/tools/libxl/libxl_pci.c
> @@ -994,7 +994,7 @@ out:
>          }
>      }
>
> -    if (!starting)
> +    if (!starting && type == LIBXL_DOMAIN_TYPE_PV)
>          rc = libxl__device_pci_add_xenstore(gc, domid, pcidev, starting);

It looks like device_pci_list reads backend/pci/ for the list of
assigned devices.  Does "libxl__device_pci_list()" still work after
this change?

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel