[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [RFC][PATCH] x86: remove vmalloc.h from asm/io.h
 
- To: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
 
- From: Ingo Molnar <mingo@xxxxxxxxxx>
 
- Date: Fri, 29 May 2015 11:21:05 +0200
 
- Cc: alsa-devel@xxxxxxxxxxxxxxxx, x86@xxxxxxxxxx, Takashi Iwai <tiwai@xxxxxxx>,	Viresh Kumar <viresh.kumar@xxxxxxxxxx>, Jaroslav Kysela <perex@xxxxxxxx>,	Kristen Carlson Accardi <kristen@xxxxxxxxxxxxxxx>,	"H. Peter Anvin" <hpa@xxxxxxxxx>, Brian Uchino <buchino@xxxxxxxxx>,	Thomas Gleixner <tglx@xxxxxxxxxxxxx>,	"K. Y. Srinivasan" <kys@xxxxxxxxxxxxx>,	linux-scsi@xxxxxxxxxxxxxxx, Vinod Koul <vinod.koul@xxxxxxxxx>,	Anton Vorontsov <anton@xxxxxxxxxx>, linux-acpi@xxxxxxxxxxxxxxx,	Ingo Molnar <mingo@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx,	Len Brown <lenb@xxxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>,	Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>,	"James E.J. Bottomley" <JBottomley@xxxxxxxx>,	Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>,	Suma Ramars <sramars@xxxxxxxxx>, Tony Luck <tony.luck@xxxxxxxxx>,	netdev@xxxxxxxxxxxxxxx, linux-pm@xxxxxxxxxxxxxxx,	Hiral Patel <hiralpat@xxxxxxxxx>, "Rafael J. Wysocki" <rjw@xxxxxxxxxxxxx>,	linux-kernel@xxxxxxxxxxxxxxx, David Vrabel <david.vrabel@xxxxxxxxxx>,	Colin Cross <ccross@xxxxxxxxxxx>, dmaengine@xxxxxxxxxxxxxxx,	devel@xxxxxxxxxxxxxxxxxxxxxx, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>,	David Miller <davem@xxxxxxxxxxxxx>
 
- Delivery-date: Fri, 29 May 2015 09:21:20 +0000
 
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
 
 
 
* Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
> Nothing in asm/io.h uses anything from vmalloc.h, so remove the include
> and fix up the build problems in an allmodconfig (64 bit and 32 bit)
> build.
> 
> This may be the place where x86 builds get vmalloc.h implicitly included
> and that tends to hide places where vmalloc() et al are added to files
> but the include of vmalloc.h is forgotten.
Good idea.
Acked-by: Ingo Molnar <mingo@xxxxxxxxxx>
> Based in Linus' tree of today.
> 
> There are probably more places that need vmalloc.h included, but this passes 
> 64 
> bit and 32 bit allmodconfig builds, so is a place to start.
Please also test x86 allnoconfig and defconfig 32/64, that tends to unearth the 
remaining places. People doing randconfig testing will find the rest.
Thanks,
        Ingo
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
 
    
     |