[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [RFC][v2][PATCH 07/14] xen/passthrough: extend hypercall to support rdm reservation policy
- To: "Chen, Tiejun" <tiejun.chen@xxxxxxxxx>, <JBeulich@xxxxxxxx>, <tim@xxxxxxx>, <konrad.wilk@xxxxxxxxxx>, <andrew.cooper3@xxxxxxxxxx>, <kevin.tian@xxxxxxxxx>, <yang.z.zhang@xxxxxxxxx>, <ian.campbell@xxxxxxxxxx>, <wei.liu2@xxxxxxxxxx>, <Ian.Jackson@xxxxxxxxxxxxx>, <stefano.stabellini@xxxxxxxxxx>
- From: Julien Grall <julien.grall@xxxxxxxxxx>
- Date: Mon, 25 May 2015 12:02:31 +0200
- Cc: xen-devel@xxxxxxxxxxxxx
- Delivery-date: Mon, 25 May 2015 10:02:45 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
On 25/05/2015 04:09, Chen, Tiejun wrote:
On 2015/5/22 18:33, Julien Grall wrote:
Hi,
On 22/05/2015 10:35, Tiejun Chen wrote:
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index 0c0ea4a..203c80e 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -499,6 +499,11 @@ struct xen_domctl_assign_device {
XEN_GUEST_HANDLE_64(char) path; /* path to the device
tree node */
} dt;
} u;
+ /* IN */
+#define XEN_DOMCTL_DEV_NO_RDM 0
+#define XEN_DOMCTL_DEV_RDM_RELAXED 1
+#define XEN_DOMCTL_DEV_RDM_STRICT 2
+ uint32_t flag; /* flag of assigned device */
You don't plumb this value for DT neither in the toolstack (see
xc_assign_dt_device) and Xen. Please add a comment saying it's only used
I think we should do this,
@@ -1801,6 +1801,8 @@ int xc_assign_dt_device(
domctl.u.assign_device.dev = XEN_DOMCTL_DEV_DT;
domctl.u.assign_device.u.dt.size = size;
+ /* DT doesn't own any RDM. */
+ domctl.u.assign_device.flag = XEN_DOMCTL_DEV_NO_RDM;
set_xen_guest_handle(domctl.u.assign_device.u.dt.path, path);
rc = do_domctl(xch, &domctl);
I would be fine with plumbing in drivers/passthrough/device_tree.c and a
check that the value is not different.
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|
