Re: [Xen-devel] [PATCH v2 18/41] arm: Introduce a generic way to use a device from acpi

[Parth Dixit <parth.dixit@xxxxxxxxxx>]

On 21 May 2015 at 16:49, Julien Grall <julien.grall@xxxxxxxxxx> wrote:

Hi Parth,

On 17/05/15 21:03, Parth Dixit wrote:
> add generic way to use device from acpi similar to
> the way it is supported in device tree.
>
> Signed-off-by: Parth Dixit <parth.dixit@xxxxxxxxxx>
> ---
> xen/arch/arm/device.c    | 19 +++++++++++++++++++
>Â xen/arch/arm/xen.lds.SÂ Â Â Â|Â 7 +++++++
>Â xen/include/asm-arm/device.h | 30 ++++++++++++++++++++++++++++++
>Â 3 files changed, 56 insertions(+)
>
> diff --git a/xen/arch/arm/device.c b/xen/arch/arm/device.c
> index 0b53f6a..5494de0 100644
> --- a/xen/arch/arm/device.c
> +++ b/xen/arch/arm/device.c
> @@ -22,6 +22,7 @@
>Â #include <xen/lib.h>
>
>Â extern const struct device_desc _sdevice[], _edevice[];
> +extern const struct acpi_device_desc _asdevice[], _aedevice[];
>
>Â int __init device_init(struct dt_device_node *dev, enum device_class class,
>Â Â Â Â Â Â Â Â Â Â Â Â Âconst void *data)
> @@ -50,6 +51,24 @@ int __init device_init(struct dt_device_node *dev, enum device_class class,
>Â Â Â return -EBADF;
>Â }
>
> +int __init acpi_device_init(enum device_class class, const void *data, int class_type)

Please explain what means class_type and how this will fit with every
ACPI device tables.

AFAICT, it does only works for SPCR table used for UART device. For the
GIC you've hardcoded the value and I can't find any version number in
the table.

You may need to introduce another way to find the device such as a
callback taking the table in parameter.

> +{
> +Â Â const struct acpi_device_desc *desc;
> +
> +Â Â for ( desc = _asdevice; desc != _aedevice; desc++ )
> +Â Â {
> +Â Â Â Â if ( ( desc->class != class ) && ( desc->class_type != class_type ) )
> +Â Â Â Â Â Â continue;
> +
> +
> +Â Â Â Â ASSERT(desc->init != NULL);
> +
> +Â Â Â Â return desc->init(data);
> +Â Â }
> +
> +Â Â return -EBADF;
> +}
> +
>Â enum device_class device_get_class(const struct dt_device_node *dev)
>Â {
>Â Â Â const struct device_desc *desc;
> diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S
> index 0488f37..60802f6 100644
> --- a/xen/arch/arm/xen.lds.S
> +++ b/xen/arch/arm/xen.lds.S
> @@ -100,6 +100,13 @@ SECTIONS
>Â Â Â Â _edevice = .;
>Â Â } :text
>
> +Â . = ALIGN(8);
> +Â .adev.info : {
> +Â Â Â _asdevice = .;
> +Â Â Â *(.adev.info)
> +Â Â Â _aedevice = .;
> +Â } :text
> +
>Â Â . = ALIGN(PAGE_SIZE);Â Â Â Â Â Â Â/* Init code and data */
>Â Â __init_begin = .;
>Â Â .init.text : {
> diff --git a/xen/include/asm-arm/device.h b/xen/include/asm-arm/device.h
> index a72f7c9..09fcfc3 100644
> --- a/xen/include/asm-arm/device.h
> +++ b/xen/include/asm-arm/device.h
> @@ -50,6 +50,27 @@ struct device_desc {
>Â Â Â int (*init)(struct dt_device_node *dev, const void *data);
>Â };
>
> +struct acpi_device_desc {
> +Â Â /* Device name */
> +Â Â const char *name;
> +Â Â /* Device class */
> +Â Â enum device_class class;
> +Â Â /* type of device supported by the driver */
> +Â Â const int class_type;
> +Â Â /* Device initialization */
> +Â Â int (*init)(const void *data);
> +};

Given that the number of device will be minimal in Xen, I would prefer
to merge this structure into device_desc by adding the ACPI fields.

It would avoid to duplicate everything for only 2 fields changes.

From the drivers point of view it would look like

DEVICE_START(....)
    .dt_init = ...
#ifdef CONFIG_ACPI
    .acpi_init = ...
#endif
DEVICE_END

Or something like

DEVICE_START(...)
    DT_INIT(...)
    ACPI_INIT(...)
DEVICE_END

And ACPI_INIT will be a no-op when CONFIG_ACPI is not enabled.

I think we agreed not to use common structure as it had some dt specific entries and there was scope of confusion.
Â

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel