Re: [Xen-devel] [PATCH v2 10/41] arm/acpi : Print GIC information when MADT is parsed

[Parth Dixit <parth.dixit@xxxxxxxxxx>]

On 18 May 2015 at 20:36, Julien Grall <julien.grall@xxxxxxxxxx> wrote:

Hi Parth,

On 17/05/15 21:03, Parth Dixit wrote:
> From: Naresh Bhat <naresh.bhat@xxxxxxxxxx>
>
> When MADT is parsed, print GIC information to make the boot
> log look pretty.
>
> Signed-off-by: Hanjun Guo <hanjun.guo@xxxxxxxxxx>
> Signed-off-by: Tomasz Nowicki <tomasz.nowicki@xxxxxxxxxx>
> Signed-off-by: Naresh Bhat <naresh.bhat@xxxxxxxxxx>
> ---
>Â xen/drivers/acpi/tables.c | 39 +++++++++++++++++++++++++++++++++++++++
>Â 1 file changed, 39 insertions(+)
>
> diff --git a/xen/drivers/acpi/tables.c b/xen/drivers/acpi/tables.c
> index 1beca79..684d8c9 100644
> --- a/xen/drivers/acpi/tables.c
> +++ b/xen/drivers/acpi/tables.c
> @@ -190,6 +190,45 @@ void __init acpi_table_print_madt_entry(struct acpi_subtable_header *header)
>Â Â Â Â Â Â Â Â}
>Â Â Â Â Â Â Â Âbreak;
>
> +Â Â case ACPI_MADT_TYPE_GENERIC_INTERRUPT:
> +Â Â Â Â {
> +Â Â Â Â Â Â struct acpi_madt_generic_interrupt *p =
> +Â Â Â Â Â Â Â Â (struct acpi_madt_generic_interrupt *)header;
> +Â Â Â Â Â Â printk(KERN_INFO PREFIX
> +Â Â Â Â Â Â Â Â "GIC (acpi_id[0x%04x] gic_id[0x%04x] %s)\n",
> +Â Â Â Â Â Â Â Â p->uid, p->gic_id,
> +Â Â Â Â Â Â Â Â (p->flags & ACPI_MADT_ENABLED) ? "enabled" : "disabled");

Printk indentation:

printk(KERN_INFO PREFIX
   Â"GIC ...
   Â...);

Also, it seems that the indentation doesn't match the rest of the switch
case.

> +Â Â Â Â }
> +Â Â Â Â break;
> +
> +Â Â case ACPI_MADT_TYPE_GENERIC_DISTRIBUTOR:
> +Â Â Â Â {
> +Â Â Â Â Â Â struct acpi_madt_generic_distributor *p =
> +Â Â Â Â Â Â Â Â (struct acpi_madt_generic_distributor *)header;
> +Â Â Â Â Â Â printk(KERN_INFO PREFIX
> +Â Â Â Â Â Â Â Â "GIC Distributor (id[0x%04x] address[0x%08llx] gsi_base[%d])\n",
> +Â Â Â Â Â Â Â Â p->gic_id, (long long unsigned int)p->base_address, p->global_irq_base);

Ditto

> +Â Â Â Â }
> +Â Â Â Â break;
> +
> +Â Â case ACPI_MADT_TYPE_GIC_MSI_FRAME:
> +Â Â Â Â {
> +Â Â Â Â Â Â struct acpi_madt_gic_msi_frame *p =
> +Â Â Â Â Â Â Â Â (struct acpi_madt_gic_msi_frame *)header;
> +Â Â Â Â Â Â printk("GIC MSI Frame (address[0x%08llx] msi_fame_id[%d])\n",
> +Â Â Â Â Â Â Â Â (long long unsigned int)p->base_address, p->gic_msi_frame_id);

Ditto & missing KERN_INFO PREFIX

> +Â Â Â Â }
> +Â Â Â Â break;
> +
> +Â Â case ACPI_MADT_TYPE_GIC_REDISTRIBUTOR:
> +Â Â Â Â {
> +Â Â Â Â Â Â struct acpi_madt_gic_redistributor *p =
> +Â Â Â Â Â Â Â Â (struct acpi_madt_gic_redistributor *)header;
> +Â Â Â Â Â Â printk("GIC Redistributor (address[0x%08llx] region_size[0x%x])\n",
> +Â Â Â Â Â Â Â Â (long long unsigned int)p->base_address, p->region_size);

Ditto & missing KERN_INFO PREFIX

Âwill take care in next patchset.

> +Â Â Â Â }
> +Â Â Â Â break;
> +
>Â Â Â Âdefault:
>Â Â Â Â Â Â Â Âprintk(KERN_WARNING PREFIX
>Â Â Â Â Â Â Â Â Â Â Â "Found unsupported MADT entry (type = %#x)\n",
>

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel