Re: [Xen-devel] [PATCH v2] x86/domctl: Fix getpageframeinfo* handling

[Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>]

On 05/20/2015 06:49 AM, Andrew Cooper wrote:
> In tree, there is one single caller of XEN_DOMCTL_getpageframeinfo3
> (xc_get_pfn_type_batch()), and no callers of the older variants.
>
> getpageframeinfo3 and getpageframeinfo2 are compatible if the parameter
> contents are considered to be unsigned long, and indeed, a compat guest
> calling getpageframeinfo3 falls through into the getpageframeinfo2 handler.
>
> However, getpageframeinfo3 and getpageframeinfo2 have different algorithms for
> calculating the eventual frame type, which means that a toolstack will get
> different answers depending on whether it is compat or not.
>
> Rewrite getpageframeinfo3 such that the code block can handle both regular and
> compat guests, and use the original getpageframeinfo3 algorithm for frame
> time, which is more complete.
>
> Remove getpageframeinfo2 and getpageframeinfo1, as they are unused and
> obsolete.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Acked-by: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel