Re: [Xen-devel] [OSSTEST v6 15/24] distros: add branch infrastructure

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2015-05-12 at 17:03 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[OSSTEST v6 15/24] distros: add branch infrastructure"):
> > Since the distro nightlies are not version controlled we cannot use
> > the usual mechanisms for detecting regressions. Special case things
> > appropriately. We use an OLD_REVISION of "flight-NNN" to signify that
> > the old revision is another flight and not a tree revision.
> 
> This all looks pretty good, except:
> 
> > -if grep -xF $NEW_REVISION $branch.force-rev; then push=$OSSTEST_PUSH; fi
> > +if test -n "$NEW_REVISION" && grep -xF $NEW_REVISION $branch.force-rev; 
> > then push=$OSSTEST_PUSH; fi
> 
> Why is it not sufficient to simply add " " around $NEW_REVISION ?

Uh, I think it is!



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel