Re: [Xen-devel] [OSSTEST v6 07/24] Debian: add preseed_create_guest helper

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2015-05-12 at 16:16 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[OSSTEST v6 07/24] Debian: add preseed_create_guest 
> helper"):
> > Creates a preseed file suitable for use in a PV guest
> ...
> > +    my $extra_packages;
> 
> Doesn't this need a value from somewhere ?

It's given one in "distros: support booting Debian PV (d-i installed)
guests with pvgrub." later on, which is clearly too late.

I'll move the definition and use to the patch which actually needs it.

> 
> The rest looks plausible.
> 
> Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel