Re: [Xen-devel] [PATCH] xen/netback: Properly initialize credit_bytes

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, May 11, 2015 at 04:58:29PM +0100, Ross Lagerwall wrote:
> Commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into queue
> struct") introduced a regression when moving queue-specific data into
> the queue struct by failing to set the credit_bytes field. This
> prevented bandwidth limiting from working. Initialize the field as it
> was done before multiqueue support was added.
> 
> Signed-off-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

This needs to be sent to netdev@xxxxxxxxxxxxxxxx

And please use "[PATCH net]" in subject line since this one is a candidate
for stable tree.

Wei.

> ---
>  drivers/net/xen-netback/xenbus.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/xen-netback/xenbus.c 
> b/drivers/net/xen-netback/xenbus.c
> index 3d8dbf5..1be3ef3 100644
> --- a/drivers/net/xen-netback/xenbus.c
> +++ b/drivers/net/xen-netback/xenbus.c
> @@ -793,7 +793,7 @@ static void connect(struct backend_info *be)
>                       goto err;
>               }
>  
> -             queue->remaining_credit = credit_bytes;
> +             queue->remaining_credit = queue->credit_bytes = credit_bytes;
>               queue->credit_usec = credit_usec;
>  
>               err = connect_rings(be, queue);
> -- 
> 2.1.0

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel