Re: [Xen-devel] [PATCH v8 5/5] libxl: Add interface for querying hypervisor about PCI topology

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2015-05-06 at 14:15 -0400, Boris Ostrovsky wrote:
> .. and use this new interface to display it along with CPU topology
> and NUMA information when 'xl info -n' command is issued
> 
> The output will look like
> ...
> cpu_topology           :
> cpu:    core    socket     node
>   0:       0        0        0
> ...
> device topology        :
> device           node
> 0000:00:00.0      0
> 0000:00:01.0      0
> ...
> 
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

[...]
> +        sysctl.u.pcitopoinfo.num_devs = num_devs - processed;
> +        set_xen_guest_handle_offset(sysctl.u.pcitopoinfo.devs, devs,
> +                                    processed * sizeof(*devs));
> +        set_xen_guest_handle_offset(sysctl.u.pcitopoinfo.nodes, nodes,
> +                                    processed * sizeof(*nodes));

Changing these in the obvious way based on my feedback to the previous
patch wouldn't invalidate my ack.

[...]
> +    if (libxl__pci_topology_init(gc, devs, *num_devs)) {
> +        LOGE(ERROR, "Cannot initialize PCI hypercall structure");

libxl__pci_topology_init might be an exception but libxl__* functions
don't typically set errno, they return ERROR_FOO things. So you may want
just LOG and not LOGE. You might also want to arrange to print the error
code.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel