Re: [Xen-devel] [PATCH v6 14/19] tools/libxl: Check if fdt_{first, next}_subnode are present in libfdt

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 08/05/15 15:27, Ian Campbell wrote:
> On Tue, 2015-04-28 at 15:32 +0100, Julien Grall wrote:
>> From: Julien Grall <julien.grall@xxxxxxxxxx>
>>
>> The functions fdt_{fisrt,next}_subnode may not be available because:
>>     * It has been introduced in 2013 => Doesn't work on Wheezy
>>     * The prototype exists but the functions are not exposed. Don't ask
>>     why...
>>
>> The later has been fixed recently in the dtc repo [1]
>>
>> When the functions are not available, implement our own in order to use
>> them in a following patch.
>>
>> [1] git://git.kernel.org/pub/scm/utils/dtc/dtc.git
>>     commit a4b093f7366fdb429ca1781144d3985fa50d0fbb
>>
>> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
>> Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
>> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
>> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
>>
>> ---
>>     tools/configure needs to be regenerate as this patch is modifying
>>     tools/configure.ac
> 
> Even with that I get on both 32 and 64-bit:
> 
> arm32:
> 
> libxl_libfdt_compat.c:63:5: error: no previous declaration for 
> âfdt_first_subnodeâ [-Werror=missing-declarations]
> libxl_libfdt_compat.c:76:5: error: no previous declaration for 
> âfdt_next_subnodeâ [-Werror=missing-declarations]
> cc1: all warnings being treated as errors
> 
> arm64:
> 
> libxl_libfdt_compat.c:63:5: error: no previous declaration for 
> 'fdt_first_subnode' [-Werror=missing-declarations]
>  int fdt_first_subnode(const void *fdt, int offset)
>      ^
> libxl_libfdt_compat.c:76:5: error: no previous declaration for 
> 'fdt_next_subnode' [-Werror=missing-declarations]
>  int fdt_next_subnode(const void *fdt, int offset)
>      ^
> cc1: all warnings being treated as errors
> 
> Is a file missing? I expected some compat in a .h file too.

I forgot to test it on a platform where the function is not present in
both the header and the library.

I will see if I can detect via the configure when the function is not
present in the headers.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel