Re: [Xen-devel] [PATCH] IOMMU/x86: avoid pages without GFN in page table creation/updating

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 07.05.15 at 15:13, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 07/05/15 13:59, Jan Beulich wrote:
>> @@ -729,12 +733,15 @@ int amd_iommu_unmap_page(struct domain *
>>       * we might need a deeper page table for lager gfn now */
>>      if ( is_hvm_domain(d) )
>>      {
>> -        if ( update_paging_mode(d, gfn) )
>> +        int rc = update_paging_mode(d, gfn);
>> +
>> +        if ( rc )
>>          {
>>              spin_unlock(&hd->arch.mapping_lock);
>>              AMD_IOMMU_DEBUG("Update page mode failed gfn = %lx\n", gfn);
> 
> Given the domain_crash(), this should probably at error priority rather
> than debug.

Not sure (and it's not debug but info level anyway, but behind an
iommu_debug check). Being unrelated to the change here, I think
this ought to be a separate change, perhaps by the AMD IOMMU
maintainers.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel