Re: [Xen-devel] [PATCH 2/3] x86/hvm: introduce functions for HVMOP_get/set_param allowance checks

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Paul Durrant
> Sent: 01 May 2015 14:39
> To: 'Jan Beulich'
> Cc: Andrew Cooper; xen-devel@xxxxxxxxxxxxxxxxxxxx; Keir (Xen.org)
> Subject: RE: [PATCH 2/3] x86/hvm: introduce functions for
> HVMOP_get/set_param allowance checks
> 
> > -----Original Message-----
> > From: Jan Beulich [mailto:jbeulich@xxxxxxxx]
> > Sent: 29 April 2015 13:29
> > To: Paul Durrant
> > Cc: Andrew Cooper; xen-devel@xxxxxxxxxxxxxxxxxxxx; Keir (Xen.org)
> > Subject: Re: [PATCH 2/3] x86/hvm: introduce functions for
> > HVMOP_get/set_param allowance checks
> >
> > >>> Paul Durrant <paul.durrant@xxxxxxxxxx> 04/24/15 6:35 PM >>>
> > >+    /* The following parameters cannot be set by the guest */
> >
> > Please add a stop ad the end of at least sentence-like comments.
> >
> 
> Ok. I tend to skip full stops for single lines and only use them for 
> multi-line.
> Just my habit though...
> 
> > >case HVM_PARAM_DM_DOMAIN:
> > >-        /* Not reflexive, as we may need to domain_pause(). */
> >
> > Especially when the reason for not allowing guest access is other than a
> > simple permission thing, I think for documentation purposes it would be
> > useful to retain these comments.
> >
> 
> I have acted upon Andrew's request for whitelists in v3 of the series, so I
> think this point is moot. I'll wait for your comments on v3 when I've posted 
> it
> (which should be today with any luck).

s/v3/v2

> 
> > a.value = current->domain->domain_id;
> >
> >          >+    /* The following parameters cannot be read by the guest */
> >
> > Perhaps "cannot" isn't the right term here - "shouldn't"?
> >
> 
> Yes, you are probably correct.
> 
>   Paul
> 
> > Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel