Re: [Xen-devel] [PATCH OSSTEST v5 04/24] Debian: refactor code to add preseed commands to the preseed file

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2015-04-15 at 11:35 +0100, Ian Campbell wrote:

> diff --git a/ts-debian-hvm-install b/ts-debian-hvm-install
> index cfd5144..95fce9a 100755
> --- a/ts-debian-hvm-install
> +++ b/ts-debian-hvm-install
> @@ -77,6 +77,9 @@ d-i preseed/late_command string \\
>          in-target mkdir -p /root/.ssh; \\
>          in-target sh -c "echo -e '$authkeys'> /root/.ssh/authorized_keys";
>  END
> +
> +    $preseed_file .= preseed_hook_cmds();

Longtao reused this patch for his nestedhvm testing series and
discovered a bug. The use of preseed_hook_cmds shadows the
preseed/late_command which is just visible here in the patch context
meaning that the authorized keys and update-rc.d are not actually run.

The code snippet needs to use a "preseed_hook_command($ho,
'late_command', $sfx, <<END);" type thing instead.

I'll fix this up in the next iteration.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel