Re: [Xen-devel] [OSSTEST Nested PATCH v8 6/7] Compose the main recipe of nested test job

["Pang, LongtaoX" <longtaox.pang@xxxxxxxxx>]

> -----Original Message-----
> From: Ian Campbell [mailto:ian.campbell@xxxxxxxxxx]
> Sent: Tuesday, April 21, 2015 6:49 PM
> To: Pang, LongtaoX
> Cc: xen-devel@xxxxxxxxxxxxx; Ian.Jackson@xxxxxxxxxxxxx; wei.liu2@xxxxxxxxxx; 
> Hu,
> Robert
> Subject: Re: [OSSTEST Nested PATCH v8 6/7] Compose the main recipe of nested
> test job
> 
> On Mon, 2015-04-13 at 17:19 -0400, longtao.pang wrote:
> > Signed-off-by: longtao.pang <longtaox.pang@xxxxxxxxx>
> > ---
> > Changes in v8:
> > Change the patch order from 6 to 5.
> > ---
> >  sg-run-job |   11 +++++++++++
> >  1 file changed, 11 insertions(+)
> >
> > diff --git a/sg-run-job b/sg-run-job
> > index eae159d..2ca5ebf 100755
> > --- a/sg-run-job
> > +++ b/sg-run-job
> > @@ -299,6 +299,17 @@ proc run-job/test-pair {} {
> >  #    run-ts . remus-failover ts-remus-check         src_host dst_host +
> debian
> >  }
> >
> > +proc need-hosts/test-nested {} {return host}
> > +proc run-job/test-nested {} {
> > +    run-ts . = ts-debian-hvm-install + host + nestedl1
> > +    run-ts . = ts-nested-setup + host + nestedl1
> > +    run-ts . = ts-xen-install nested_l1
> > +    run-ts . = ts-host-reboot nested_l1
> > +    run-ts . = ts-debian-hvm-install nested_l1 nestedl2
> > +    run-ts . = ts-guest-stop nested_l1 nestedl2
> > +    run-ts . = ts-guest-destroy host nestedl1
> 
> Based on my comments to previous patches I think you'll want to use
> nestedl1 and nestedl2 consistently and never nested_l1/nested_l2.
> 
nestedl1 nestedl2 are hostname for L1 guest VM and L2 guest VM, nested_l1 and 
nested_l2 are ident for L1 and L2.

> You may also need to pass an extra nestedl2 to ts-nested-setup based on
> my feedback there.
> 
> What testid's does this all generate? If you run
>         ./standalone run-job --simulate <jobname> | grep testid
> (If your osstest doesn't include the --simulate option yet then either
> upgrade or set OSSTEST_SIMULATE=1 in your environment)
> 
Could you please make it clear, since I failed to run the above command, or do 
I need some other settings?
For example: './standalone run-job --simulate test-amd64-amd64-xl | grep 
testid', just get below messages:
#./standalone run-job --simulate test-amd64-amd64-xl | grep testid
Could not open a connection to your authentication agent.
WARNING: Unable to access ssh-agent. Some tests may fail
run-job: Need a host

> Then it will include a load of lines like
>         2015-04-21 10:44:57 Z standalone.test-amd64-amd64-xl ========== 1
> testid build-check(1) ==========
>         2015-04-21 10:44:57 Z standalone.test-amd64-amd64-xl ========== 2
> testid hosts-allocate ==========
>         2015-04-21 10:44:57 Z standalone.test-amd64-amd64-xl ========== 3
> testid host-install(3) ==========
>         2015-04-21 10:44:57 Z standalone.test-amd64-amd64-xl ========== 4
> testid host-ping-check-native ==========
>         2015-04-21 10:44:57 Z standalone.test-amd64-amd64-xl ========== 5
> testid xen-install ==========
>         2015-04-21 10:44:57 Z standalone.test-amd64-amd64-xl ========== 6
> testid xen-boot ==========
>         2015-04-21 10:44:57 Z standalone.test-amd64-amd64-xl ========== 7
> testid host-ping-check-xen ==========
>         2015-04-21 10:44:57 Z standalone.test-amd64-amd64-xl ========== 8
> testid leak-check/basis(8) ==========
>         2015-04-21 10:44:57 Z standalone.test-amd64-amd64-xl ========== 9
> testid debian-install ==========
>         2015-04-21 10:44:57 Z standalone.test-amd64-amd64-xl ========== 10
> testid debian-fixup ==========
>         2015-04-21 10:44:57 Z standalone.test-amd64-amd64-xl ========== 11
> testid guest-start ==========
>         2015-04-21 10:44:57 Z standalone.test-amd64-amd64-xl ========== 12
> testid migrate-support-check ==========
>         2015-04-21 10:44:57 Z standalone.test-amd64-amd64-xl ========== 13
> testid guest-saverestore ==========
>         2015-04-21 10:44:57 Z standalone.test-amd64-amd64-xl ========== 14
> testid guest-localmigrate ==========
>         2015-04-21 10:44:57 Z standalone.test-amd64-amd64-xl ========== 15
> testid guest-saverestore.2 ==========
>         2015-04-21 10:44:57 Z standalone.test-amd64-amd64-xl ========== 16
> testid guest-localmigrate.2 ==========
>         2015-04-21 10:44:57 Z standalone.test-amd64-amd64-xl ========== 17
> testid guest-localmigrate/x10 ==========
>         2015-04-21 10:44:57 Z standalone.test-amd64-amd64-xl ========== 18
> testid guest-stop ==========
>         2015-04-21 10:44:57 Z standalone.test-amd64-amd64-xl ========== 19
> testid guest-start.2 ==========
>         2015-04-21 10:44:57 Z standalone.test-amd64-amd64-xl ========== 20
> testid guest-start/debian.repeat ==========
>         2015-04-21 10:44:57 Z standalone.test-amd64-amd64-xl ========== 21
> testid guest-destroy ==========
>         2015-04-21 10:44:57 Z standalone.test-amd64-amd64-xl ========== 22
> testid leak-check/check ==========
>         2015-04-21 10:44:57 Z standalone.test-amd64-amd64-xl ========== 23
> testid capture-logs(23) ==========
> 
> The placement of the + in the recipe affect whether a parameter is
> included in the test id or not, I'm not sure but you might want/need one
> or two in the ts-guest-destroy-step?
> 
> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel