Re: [Xen-devel] [PATCH 6/7] docs/build: Move install checks into individual build targets

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Mon, 2015-04-20 at 13:01 +0100, Andrew Cooper wrote:
> On 20/04/15 12:57, Jan Beulich wrote:
> >>>> On 20.04.15 at 12:49, <andrew.cooper3@xxxxxxxxxx> wrote:
> >> @@ -103,12 +88,20 @@ install: install-man-pages install-html
> >>  
> >>  # Individual file build targets
> >>  man1/%.1: man/%.pod.1 Makefile
> >> +ifdef POD2MAN
> > Perhaps better to use ifneq($(POD2MAN),) in such cases?
> 
> I was following the prevailing style, but can update all instances. 
> FWIW, it is not currently an issue.

I don't really mind, ifneq seems more prevalent in other makefiles, I'm
not sure why this one uses ifdef nor really what the implications are.

> >>    @$(INSTALL_DIR) $(@D)
> >>    $(POD2MAN) --release=$(VERSION) --name=$* -s 1 -c "Xen" $< $@
> >> +else
> >> +  @echo "pod2man not installed; skipping $(@F)"
> > Why do you strip off the directory part? Leaving it in place would
> > make the output even less ambiguous (and hence more helpful).
> 
> Can do.

Thanks.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel