Re: [Xen-devel] [OSSTEST Nested PATCH v8 3/7] Edit some APIs in TestSupport.pm for nested test

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [OSSTEST Nested PATCH v8 3/7] Edit some APIs in 
TestSupport.pm for nested test"):
> On Mon, 2015-04-13 at 17:19 -0400, longtao.pang wrote:
> > --- a/Osstest/TestSupport.pm
> > +++ b/Osstest/TestSupport.pm
...
> > +    if ( $r{"${name}_ip"} ) {
> > +        $setprop->("IpAddr", $r{"${name}_ip"});
> > +    }
> 
> This is one for Ian I think, but I suspect this should use ${ident}
> rather than ${name}. 

Yes.

> ${ident} is e.g. 'host' or 'srchost' or 'nestedl1' it is the prefer used
> on the runvar names. ${name} is the specific value assigned, i.e. an
> actual host name.
> 
> For such properties we usually prefer ${ident}_foo. Ian, correct me if
> I'm wrong please.

Ian C is right.


But, I think actually the principle behind this change is wrong.

It seems to be copying information from runvars into the in-memory
data structure for host properties.  But host properties are (by
definition) matters of (fixed) configuration, not runtime definition.

I haven't looked at the rest of the series, but the same effect should
be achieved in a different way.  Note that a $ho is a hash which
already contains (after selecthost, say) an element with key `Ip'.

So the right place to do this is indeed probably somewhere around
selectguest or selecthost, but the information should be put into
$ho->{Ip} without going via host properties.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel