Re: [Xen-devel] [PATCH 1/8] raisin: Fix non-verbose case

[George Dunlap <george.dunlap@xxxxxxxxxxxxx>]

On 04/17/2015 11:06 AM, Stefano Stabellini wrote:
> On Thu, 16 Apr 2015, George Dunlap wrote:
>> Because we use "set -e", we can't use the "a && b" construct, as it will 
>> fail and stop the script.
>>
>> Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
> 
> I am wondering whether we should ban both a && b and a || b from the
> code and just go with the more verbose but also harder to get wrong:
> 
> if [[ $VERBOSE -eq 1 ]]
> then
>     echo calling "$component"_"$1"
> fi
> 
> Reading the code and seeing a || b will tempt you into writing a && b.

That's a good point. :-)  Do you want to go it or shall I resend?

 -George


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel