Re: [Xen-devel] [PATCH] passthrough/amd: avoid reading an uninitialized variable.

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 16/04/15 17:44, Tim Deegan wrote:
> update_intremap_entry_from_msi() doesn't write to its data pointer on
> some error paths, so we copying that variable into the msg would count
> as undefined behaviour.
>
> Signed-off-by: Tim Deegan <tim@xxxxxxx>
> Cc: Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>
> Cc: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@xxxxxxx>

This looks curiously familiar.

http://lists.xen.org/archives/html/xen-devel/2015-03/msg03679.html

I was meaning to get around to submitting it as a formal patch, but you
have definitely beaten me to it :)

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel