Re: [Xen-devel] [PATCH v3 1/3] xen/pvh: enable mmu_update hypercall

[Tim Deegan <tim@xxxxxxx>]

At 14:10 +0100 on 14 Apr (1429020603), Andrew Cooper wrote:
> On 14/04/15 13:03, Roger Pau Monné wrote:
> > El 14/04/15 a les 13.55, Jan Beulich ha escrit:
> >>>>> On 10.04.15 at 19:29, <roger.pau@xxxxxxxxxx> wrote:
> >>> This is needed for performing save/restore of PV guests.
> >>>
> >>> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> >>> Cc: Tim Deegan <tim@xxxxxxx>
> >>> Cc: Jan Beulich <jbeulich@xxxxxxxx>
> >>> Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> >>> ---
> >>> Once migration v2 has been merged this patch can be reverted, since it
> >>> removes the need to use the MMU_MACHPHYS_UPDATE hypercall.
> >> Didn't earlier discussion end with the request to limit PVH access to
> >> just this one sub-op?
> > My bad, from the last conversation I got the feeling that the other
> > sub-ops already had the needed checks so it was fine to enable them. I
> > know the checks are there, and using the other sub-ops from a PVH guest
> > should be fine, but I guess it's better to just enable what we really need.
> 
> I would be in favour of dropping this patch entirely, as there is
> agreement in principle from the toolstack maintainers to include
> migration v2 in its current state.

+1.

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel