Re: [Xen-devel] [PATCH v6 4/5] libxl/libxc: Move libxl_get_numainfo()'s hypercall buffer management to libxc

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Mon, 2015-04-06 at 18:12 -0400, Boris Ostrovsky wrote:
> xc_numainfo() is not expected to be used on a hot path and therefore
> hypercall buffer management can be pushed into libxc. This will simplify
> life for callers.
> 
> Also update error logging macros.
> 
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
> ---
> 
> Changes in v6:
> * Dropped separate NULL buffer tests in xc_numainfo()
> * Moved test for buffers validity (either both or neither are NULL) to be the
>   the first thing to do in xc_numainfo()

I suppose this last bit will be impacted by the discussion on #1? In any
case as long as this check ends up matching the hypercall semantics, as
to be agreed with the hypervisor maintainers, then you may add my:

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel