Re: [Xen-devel] [PATCH v3 2/3] xen/shadow: fix shadow_track_dirty_vram to work on hvm guests

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 10.04.15 at 19:29, <roger.pau@xxxxxxxxxx> wrote:
> Modify shadow_track_dirty_vram to use a local buffer and then flush to the
> guest without the paging_lock held. This is modeled after
> hap_track_dirty_vram.

And hence introduces the same issue: The HVMOP_track_dirty_vram
handler explicitly allows for up to 1Gb of VRAM, yet here you
effectively limit things to 128Mb (one page worth of bits each taking
care of one guest page) considering heavily fragmented memory.

Apart from that the patch would need cleaning up for coding style.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel