Re: [Xen-devel] [PATCH v4 04/12] x86: maintain COS to CBM mapping for each socket

[Chao Peng <chao.p.peng@xxxxxxxxxxxxxxx>]

On Thu, Apr 09, 2015 at 10:35:43PM +0100, Andrew Cooper wrote:
> On 09/04/2015 10:18, Chao Peng wrote:
> >  struct psr_cat_socket_info {
> >      bool_t initialized;
> >      bool_t enabled;
> >      unsigned int cbm_len;
> >      unsigned int cos_max;
> > +    struct psr_cat_cbm *cos_cbm_map;
> 
> "cos_to_cmb" would be more in keeping with Xen style, and IMO easier to
> read in code.

Yeah, I like this name.

> 
> >  };
> >  
> >  struct psr_assoc {
> > @@ -240,6 +246,14 @@ static void cat_cpu_init(unsigned int cpu)
> >          info->cbm_len = (eax & 0x1f) + 1;
> >          info->cos_max = (edx & 0xffff);
> 
> Apologies for missing this in the previous patch, but cos_max should
> have a command line parameter like rmid_max if a lower limit wants to be
> enforced.

OK, I will add it.

Thanks,
Chao

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel