Re: [Xen-devel] [PATCH 3/6] x86/smp: Clean up use of memflags in cpu_smpboot_alloc()

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 09/04/15 16:02, Tim Deegan wrote:
> At 18:26 +0100 on 07 Apr (1428431177), Andrew Cooper wrote:
>> Hoist MEMF_node(cpu_to_node(cpu)) to the start of the function, and avoid
>> passing (potentially bogus) memflags if node information is not available.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> As it happens, MEMF_node(NUMA_NO_NODE) is already == 0.

Only because of a masked overflow.  That is why (potentially) is in
brackets.

> I'm not sure if that's by design or not, but this looks robuster. :)

Indeed.

>
> Reviewed-by: Tim Deegan <tim@xxxxxxx>

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel