Re: [Xen-devel] [RFC PATCH COLO v5 05/29] Introduce a new internal API libxl__domain_unpause()

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Apr 01, 2015 at 02:41:41PM +0800, Yang Hongyang wrote:
> From: Wen Congyang <wency@xxxxxxxxxxxxxx>
> 
> The guest is paused after libxl_domain_create_restore().
> Secondary vm is running in colo mode. So we need to unpause
> the guest. The current API libxl_domain_unpause() is
> not an internal API. Introduce a new API to support it.
> 

It would be good if you can say "No functional change" in commit log in
the future.

> Signed-off-by: Wen Congyang <wency@xxxxxxxxxxxxxx>
> ---
>  tools/libxl/libxl.c          | 21 +++++++++++++++------
>  tools/libxl/libxl_internal.h |  1 +
>  2 files changed, 16 insertions(+), 6 deletions(-)
> 
> diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
> index 6e55afc..c3898ce 100644
> --- a/tools/libxl/libxl.c
> +++ b/tools/libxl/libxl.c
> @@ -1037,9 +1037,8 @@ out:
>      return AO_INPROGRESS;
>  }
>  
> -int libxl_domain_unpause(libxl_ctx *ctx, uint32_t domid)
> +int libxl__domain_unpause(libxl__gc *gc, uint32_t domid)
>  {
> -    GC_INIT(ctx);
>      char *path;
>      char *state;
>      int ret, rc = 0;
> @@ -1059,12 +1058,22 @@ int libxl_domain_unpause(libxl_ctx *ctx, uint32_t 
> domid)
>                                           NULL, NULL, NULL);
>          }
>      }
> -    ret = xc_domain_unpause(ctx->xch, domid);
> -    if (ret<0) {
> -        LIBXL__LOG_ERRNO(ctx, LIBXL__LOG_ERROR, "unpausing domain %d", 
> domid);
> +
> +    ret = xc_domain_unpause(CTX->xch, domid);
> +    if (ret < 0) {
> +        LOGE(ERROR, "unpausing domain %d", domid);
>          rc = ERROR_FAIL;
>      }
> - out:
> +
> +out:

Nit, this change is not strictly necessary.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel