Re: [Xen-devel] [OSSTEST Nested PATCH v7 5/6] Add test job for nest test case

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2015-04-01 at 08:27 +0000, Pang, LongtaoX wrote:
> 
> 
> > -----Original Message-----
> > From: Ian Campbell [mailto:ian.campbell@xxxxxxxxxx]
> > Sent: Tuesday, March 31, 2015 10:23 PM
> > To: Pang, LongtaoX
> > Cc: xen-devel@xxxxxxxxxxxxx; Ian.Jackson@xxxxxxxxxxxxx; wei.liu2@xxxxxxxxxx;
> > Hu, Robert
> > Subject: Re: [OSSTEST Nested PATCH v7 5/6] Add test job for nest test case
> > 
> > On Fri, 2015-03-27 at 19:06 -0400, longtao.pang wrote:
> > > 1. This patch adds creation of the nested test job, when job creation
> > > procedure is invoked.
> > > 2. 'NESTED_OS_IMAGE' is the name of 'Debian ISO Images', which defined
> > > in standalone.config.
> > 
> > It will need to be defined in production-config too, and it will need to be 
> > made
> > available on the infra, which probably involves you telling us which ISO is
> > needed.
> > 
> > Or even better, use the same value as the existing Debian test, i.e.
> > debian-7.2.0-amd64-CD-1.iso which is hardcoded in make-flight but would be
> > better off refactored into production-config
> >
> We create a 'standalone.config' and defined 'export 
> NESTED_OS_IMAGE=debian-7.6.0-amd64-DVD-1.iso' in this config.
> I'm sorry, what's 'production-config' used for? It seems that we have not 
> used it before. Could you please make it more clearly?

standalone.config is only used in standalone mode, in production mode
(i.e. on the proper infrastructure and running from cron)
production-config is used instead.

In standalone mode the equivalent to production-config is, by default,
~/.xen-osstest/config or you can set it with the -c option to the
standalone helper script.

Those options area accessed from Perl with $c{Name} and from shell with
`getconfig Name`.

I think you could probably get away with just hardcoding
debian-7.2.0-amd64-CD-1.iso in make-flight.

Note the version I said there is different to the one you used but is
the same as the other instance in make-flight. I think they should be
the same so if you really need 7.6.0 DVD for some reason then I think we
should make everything use that, but I hope that isn't necessary.

Ideally all of the runvars which are assigned an iso image would use the
config, but I don't think you need to be the one to do that.

> > > 3. Set nested L1's vif model as e1000 by make-flight.
> > >
> > > Signed-off-by: longtao.pang <longtaox.pang@xxxxxxxxx>
> > 
> > I think this needs to go after the next patch, else the recipe doesn't 
> > exist yet.
> >
> I'm sorry, I don't understand your meaning. Could you please make it more 
> clearly? 

Here you add a job which uses test-nested as the recipe, but you don't
patch sg-run-job to define that recipe until the next patch, so you
should swap the order of the two patches.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel