Re: [Xen-devel] [PATCH v3 1/5] libxl: introduce libxl__device_model_xs_path

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Mar 24, 2015 at 02:32:42PM +0000, Ian Campbell wrote:
> On Fri, 2015-03-20 at 16:19 +0000, Wei Liu wrote:
> > +_hidden char *libxl__device_model_xs_path(libxl__gc *gc, uint32_t dm_domid,
> > +                                          uint32_t domid,
> > +                                          const char *format,  ...);
> 
> This should have the PRINTF_ATTRIBUTE thing and not the double space
> before "...".
> 
> With that fixed: Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
> Since this is pretty minor if you want to resend just this one patch, or
> even send an incremental fixup to be folded in I can take care of it on
> commit.
> 

Here is an incremental fix.

---8<---
From fe43ae63bc0bc9e43af6957566e51c2f5a9edd29 Mon Sep 17 00:00:00 2001
From: Wei Liu <wei.liu2@xxxxxxxxxx>
Date: Tue, 24 Mar 2015 14:47:51 +0000
Subject: [PATCH] libxl__device_model_xs_path fixup

---
 tools/libxl/libxl_internal.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
index 1e9ee59..d6daf62 100644
--- a/tools/libxl/libxl_internal.h
+++ b/tools/libxl/libxl_internal.h
@@ -1798,7 +1798,7 @@ _hidden int libxl__device_model_version_running(libxl__gc 
*gc, uint32_t domid);
 _hidden libxl_device_model_version libxl__default_device_model(libxl__gc *gc);
 _hidden char *libxl__device_model_xs_path(libxl__gc *gc, uint32_t dm_domid,
                                           uint32_t domid,
-                                          const char *format,  ...);
+                                          const char *format, ...) 
PRINTF_ATTRIBUTE(4, 5);
 
 /* Check how executes hotplug script currently */
 int libxl__hotplug_settings(libxl__gc *gc, xs_transaction_t t);
-- 
1.9.1


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel