Re: [Xen-devel] [PATCH 05/29] libxl: suspend: Return correct error from callbacks

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2015-02-10 at 20:09 +0000, Ian Jackson wrote:
> If a suspend callback fails, it has a libxl error code in its hand.
> However we must return to libxc the values that libxc expects.  So we
> stash the libxl error code in dss->rc and fish it out again after
> libxc returns from the suspend call.
> 
> While we're here, abolish the now-redundant `ok' variable in
> remus_devices_postsuspend_cb.
> 
> The overall functional change is that libxl_domain_save now completes
> with the correct error code as determined when the underlying failure
> happened.  (Usually this is, still, ERROR_FAIL.)
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel