Re: [Xen-devel] [PATCH 01/29] libxl: Further fix exit paths from libxl_device_events_handler

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2015-02-18 at 17:23 +0100, Roger Pau Monnà wrote:
> El 10/02/15 a les 21.09, Ian Jackson ha escrit:
> > On the success path, do not call GC_FREE explicitly.  Instead, call
> > AO_INPROGRESS.
> > 
> > GC_FREE will free the gc underlying the long-term ao, which is then
> > subsequently referenced in backend_watch_callback's call to
> > libxl__nested_ao_create.  It is a miracle that this ever works at all.
> > 
> > Also, add an `if (rc) goto out;' after the xswatch registration.
> > 
> > After this, libxl_device_events_handler has the conventional and
> > correct ao initiation pattern.
> > 
> > Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> 
> Acked-by: Roger Pau Monnà <roger.pau@xxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel