Re: [Xen-devel] [PATCH 4/5] hvmloader: add knob for fixed SMBIOS date string

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 23.03.15 at 10:15, <olaf@xxxxxxxxx> wrote:
> On Mon, Mar 23, Jan Beulich wrote:
> 
>> >>> On 20.03.15 at 18:24, <olaf@xxxxxxxxx> wrote:
>> > To allow reproducible builds of hvmloader introduce a make variable
>> > SMBIOS_REL_DATE=mm/dd/yyyy to provide a fixed date string. Without this
>> > change the hvmloader binary changes with every rebuild.
>> 
>> I don't really object to this change, but didn't we discuss using
>> smbios.c's time stamp instead, which then would properly reflect
>> eventual changes during incremental builds along with producing
>> unchanged output when there hasn't been any change?
> 
> Using the file timestamp will actually break the attempt to get a
> reproducible build if the file is patched during package build.
> With each rebuild patch(1) will alter the timestamp.

Oh, right, so it's really the default we may want to alter. But that's
not subject of this patch then, so I'll go ack it.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel