Re: [Xen-devel] [PATCH 3/3] libxl: Domain destroy: fork

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2015-03-20 at 09:14 -0600, Jim Fehlig wrote:
> Ian Campbell wrote:
> > On Tue, 2015-03-17 at 09:30 -0600, Jim Fehlig wrote:
> >   
> >> diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
> >> index b6541d4..b43db1a 100644
> >> --- a/tools/libxl/libxl.c
> >> +++ b/tools/libxl/libxl.c
> >> @@ -1481,6 +1481,10 @@ static void domain_destroy_callback(libxl__egc *egc,
> >>  static void destroy_finish_check(libxl__egc *egc,
> >>                                   libxl__domain_destroy_state *dds);
> >>  
> >> +static void domain_destroy_domid_cb(libxl__egc *egc,
> >> +                                    libxl__ev_child *destroyer,
> >> +                                    pid_t pid, int status);
> >>     
> >
> > This seems misplaced, doesn't it want to go before libxl__destroy_domid
> > just after the prototype of devices_destroy_cb, which is where it lives
> > in the sequence?
> >   
> 
> Yes, I think you are right. Here an adjusted patch.

Acked + applied, thanks!



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel