Re: [Xen-devel] [PATCH v4 26/33] xen/passthrough: Extend XEN_DOMCTL_*assign_device to support DT device

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 19.03.15 at 20:29, <julien.grall@xxxxxxxxxx> wrote:
> @@ -344,6 +344,13 @@ int iommu_do_domctl(
>      ret = iommu_do_pci_domctl(domctl, d, u_domctl);
>  #endif
>  
> +#ifdef HAS_DEVICE_TREE
> +    if ( ret != -ENODEV)
> +        return ret;
> +
> +    ret = iommu_do_dt_domctl(domctl, d, u_domctl);
> +#endif
> +
>      return ret;
>  }

I think inverting the if() condition and avoiding the extra return
path would be better, particularly in case any new code would get
added between the #endif and the final return. With that done
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
for the non-ARM, non-tools parts.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel