Re: [Xen-devel] [PATCH 4/7] xen: print online pCPUs and free pCPUs when dumping scheduler info

[George Dunlap <george.dunlap@xxxxxxxxxxxxx>]

On 03/16/2015 05:05 PM, Dario Faggioli wrote:
> e.g., with  `xl debug-key r'. This change adds something
> like the following lines to the dump output:
> 
>   (XEN) Num online Cpus: 16, cpu_online_map: 0-15
>   (XEN) Num free Cpus: 8, cpupool_free_cpus: 8-15
> 
> Meaning there are 16 pCPUs online, and they are pCPUs
> 0-15, and that 8 of them, more specifically 8-15, are
> not part of any cpupool.
> 
> Signed-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> Cc: Juergen Gross <JGross@xxxxxxxx>
> Cc: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
> Cc: Jan Beulich <JBeulich@xxxxxxxx>
> Cc: Keir Fraser <keir@xxxxxxx>
> ---
>  xen/common/cpupool.c |   13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/xen/common/cpupool.c b/xen/common/cpupool.c
> index cd6aab9..3bf0174 100644
> --- a/xen/common/cpupool.c
> +++ b/xen/common/cpupool.c
> @@ -17,6 +17,7 @@
>  #include <xen/percpu.h>
>  #include <xen/sched.h>
>  #include <xen/sched-if.h>
> +#include <xen/keyhandler.h>
>  #include <xen/cpu.h>
>  
>  #define for_each_cpupool(ptr)    \
> @@ -658,6 +659,12 @@ int cpupool_do_sysctl(struct xen_sysctl_cpupool_op *op)
>      return ret;
>  }
>  
> +static void _print_cpumap(const char *str, const cpumask_t *map)

Is there a particular reason to put "_" in front of a static function?

This has Juergen's Ack now, so that's just a suggestion / comment. :-)

 -George


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel