Re: [Xen-devel] Xen-unstable: "root=" no longer prepended on kernel cmdline since commit "tools: xl: handle unspecified extra= when dealing with root="

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2015-03-13 at 10:05 +0000, Wei Liu wrote:
> On Thu, Mar 12, 2015 at 05:59:06PM +0000, Ian Campbell wrote:
> > On Thu, 2015-03-12 at 18:48 +0100, Sander Eikelenboom wrote:
> > > Hi Ian,
> > > 
> > > My PV-guest configs were still using the old "root=" option,
> > > but these guests don't boot anymore since:
> > > commit 49ab17a3a615e1ab4ccc46d6942f925cf841df4b,
> > > "tools: xl: handle unspecified extra= when dealing with root="
> > > 
> > > These pv guests don't boot anymore since the "root=" part isn't
> > > prepended anymore on the kernel commandline, leading to
> > > a guest kernel that is incapable of finding the root partition.
> > 
> > Bugger, you are of course absolutely correct.
> > 
> > How about this, compile tested only...
> > 
> > 8<-------------
> > 
> > >From fc8eed8083d87608df7b836d89ba058066206b6c Mon Sep 17 00:00:00 2001
> > From: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > Date: Thu, 12 Mar 2015 17:56:47 +0000
> > Subject: [PATCH] tools: xl: prepend root= to root field on command line with
> >  no extra
> > 
> > This was broken in 49ab17a3a615 "tools: xl: handle unspecified extra=
> > when dealing with root=".
> > 
> > Reported-by: Sander Eikelenboom <linux@xxxxxxxxxxxxxx>
> > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Applied, with a tested-by from Sander too.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel