Re: [Xen-devel] [PATCH V13 1/7] xen/arm: p2m changes for mem_access support

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 12/03/15 14:10, Andrew Cooper wrote:
> On 12/03/15 13:56, Ian Campbell wrote:
>> On Thu, 2015-03-12 at 12:57 +0000, Julien Grall wrote:
>>> Hi Tamas,
>>>
>>> On 06/03/15 21:24, Tamas K Lengyel wrote:
>>>> @@ -1090,6 +1098,8 @@ void p2m_teardown(struct domain *d)
>>>>  
>>>>      p2m_free_vmid(d);
>>>>  
>>>> +    radix_tree_destroy(&p2m->mem_access_settings, NULL);
>>>> +
>>>>      spin_unlock(&p2m->lock);
>>>>  }
>>>>  
>>>> @@ -1115,6 +1125,10 @@ int p2m_init(struct domain *d)
>>>>      p2m->max_mapped_gfn = 0;
>>>>      p2m->lowest_mapped_gfn = ULONG_MAX;
>>>>  
>>>> +    p2m->default_access = p2m_access_rwx;
>>>> +    p2m->mem_access_enabled = false;
>>> false is defined for bool not bool_t.
>>> Please use 0 here.
>> I'm not convinced, false is false whatever you assign it to.
> 
> C specified that false expands to the constant 0, and true to the
> constant 1.
> 
> They are fine for use with any integral type.

It's still mixing types... which are defined in different headers.

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel