Re: [Xen-devel] [PATCH 5/9] libxl: introduce libxl_cpupool_cpu{add, remove}_cpumap()

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Mar 09, 2015 at 11:31:09AM +0000, Dario Faggioli wrote:
[...]
> > > --- a/tools/libxl/libxl.h
> > > +++ b/tools/libxl/libxl.h
> > > @@ -1456,8 +1456,12 @@ int libxl_cpupool_destroy(libxl_ctx *ctx, uint32_t 
> > > poolid);
> > >  int libxl_cpupool_rename(libxl_ctx *ctx, const char *name, uint32_t 
> > > poolid);
> > >  int libxl_cpupool_cpuadd(libxl_ctx *ctx, uint32_t poolid, int cpu);
> > >  int libxl_cpupool_cpuadd_node(libxl_ctx *ctx, uint32_t poolid, int node, 
> > > int *cpus);
> > > +int libxl_cpupool_cpuadd_cpumap(libxl_ctx *ctx, uint32_t poolid,
> > > +                                const libxl_bitmap *cpumap);
> > >  int libxl_cpupool_cpuremove(libxl_ctx *ctx, uint32_t poolid, int cpu);
> > >  int libxl_cpupool_cpuremove_node(libxl_ctx *ctx, uint32_t poolid, int 
> > > node, int *cpus);
> > > +int libxl_cpupool_cpuremove_cpumap(libxl_ctx *ctx, uint32_t poolid,
> > > +                                   const libxl_bitmap *cpumap);
> > >  int libxl_cpupool_movedomain(libxl_ctx *ctx, uint32_t poolid, uint32_t 
> > > domid);
> > >  int libxl_cpupool_info(libxl_ctx *ctx, libxl_cpupoolinfo *info, uint32_t 
> > > poolid);
> > >  
> > 
> > Missing #define LIBXl_HAVE_$FOO.
> > 
> So, do we need to do this every time we add a new function, even if not
> changing any existing one, not adding fields to any data structure,
> etc.?
> 

IMHO this needs one.

Consider a new client which uses this API compiles against old library.
The same reason why we add LIBXL_HAVE_$FOO for any structure changes.

Wei.

> Regards,
> Dario



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel