Re: [Xen-devel] [PATCH] test_x86_emulate: fix inline assembly in blowfish code

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 06/03/2015 11:30, Jan Beulich wrote:
> With certain gcc versions, commit 1166ecf781 ("tools/Rules.mk: Don't
> optimize debug builds; add macro debugging information") results in the
> file scope inline assembly no longer being emitted to the .text section
> without explicitly switching to it, which causes the blowfish test to
> signal SEGV.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

>
> --- a/tools/tests/x86_emulator/blowfish.c
> +++ b/tools/tests/x86_emulator/blowfish.c
> @@ -21,7 +21,8 @@ Foundation, Inc., 59 Temple Place, Suite
>  uint64_t blowfish_test(uint64_t input);
>  
>  asm (
> -    ".globl _start\n"
> +    "\t.text\n"
> +    "\t.globl _start\n"
>      "_start:\n"
>  #if defined(__i386__)
>      "push %edx; push %eax; "
>
>
>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel