[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen/arm: gic: GICv2 & GICv3 only supports 1020 physical interrupts



On Tue, 2015-03-03 at 16:35 +0000, Julien Grall wrote:
> +    gicv3_info.nr_lines = min((unsigned)1020, nr_lines);

"1020U" is the correct way to write (unsigned)1020 I think (in both
places).

Otherwise looks ok, although I had to look twice to figure out that the
register initialisation was the same afterwards.

Where does this value get used? Can you spell it out in the commit log
please.

In particular are you sure that there are no usages which assume this is
a multiple of 32?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.