Re: [Xen-devel] [PATCH v6 02/23] xen: move NUMA_NO_NODE to public memory.h as XEN_NUMA_NO_NODE

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 02.03.15 at 18:00, <wei.liu2@xxxxxxxxxx> wrote:
> There are two issues here irrespective of this series:
> 
> 1. should we expose that sentinel in ABI?
> 2. if so, what should the sentinel be?
> 
> I think Andrew and you disagree on the first one. We can work out the
> answer to the second question later.

I very much think that if we want to allow a "no node" specification
via the domctl, then this should be part of the ABI. But that value
and its (implicit) equivalent used for memops don't need to be the
same, and it looks like they can't. And looking at this I think the
code we have right now needs fixing: The internal vnode_to_pnode
array should become nodeid_t[], and input from the domctl should
be validated to either be a valid pnode or the to be defined sentinel
(which then, due to being stored as a more narrow type, needs
translation to NUMA_NO_NODE).

If we don't want to allow "no node", then input should be validated
to present valid pnodes.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel