[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/4] vscsiif.h: remove reference to WWN



On 03/02/2015 11:15 AM, Olaf Hering wrote:
The code in xend, xenlinux and pvops 3.18 expects the h:c:t:l notation.
Remove incorrect reference to WWN because it was never supported. And
its not clear how it could be supported. p-devname can be used to store
a config string.

The pvops backend driver should support the WWN notation. In case it
isn't working this is a bug which should be repaired.

I implemented the WWn version before adding the possibility to use
h:c:t:l due to compatibility with xend...

So: NAK.


Juergen


Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Cc: Jan Beulich <jbeulich@xxxxxxxx>
Cc: Keir Fraser <keir@xxxxxxx>
Cc: Tim Deegan <tim@xxxxxxx>
---
  xen/include/public/io/vscsiif.h | 5 ++---
  1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/xen/include/public/io/vscsiif.h b/xen/include/public/io/vscsiif.h
index 7a1db05..373ca3f 100644
--- a/xen/include/public/io/vscsiif.h
+++ b/xen/include/public/io/vscsiif.h
@@ -58,9 +58,8 @@
   * p-dev
   *      Values:         string
   *
- *      A string specifying the backend device: either a 4-tuple "h:c:t:l"
- *      (host, controller, target, lun, all integers), or a WWN (e.g.
- *      "naa.60014054ac780582").
+ *      A string specifying the backend device in form of a 4-tuple "h:c:t:l"
+ *      (host, controller, target, lun, all integers).
   *
   * v-dev
   *      Values:         string

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.