Re: [Xen-devel] [PATCH] xen: Remove trailing semicolon of macro so it can be used in 'if' statement

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 01/03/15 10:57, Yuval Shaia wrote:
> Signed-off-by: Yuval Shaia <yuval.shaia@xxxxxxxxxx>
> ---
>  include/xen/xenbus.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/xen/xenbus.h b/include/xen/xenbus.h
> index b78f21c..b0f1c9e 100644
> --- a/include/xen/xenbus.h
> +++ b/include/xen/xenbus.h
> @@ -114,9 +114,9 @@ int __must_check __xenbus_register_backend(struct 
> xenbus_driver *drv,
>                                          const char *mod_name);
>  
>  #define xenbus_register_frontend(drv) \
> -     __xenbus_register_frontend(drv, THIS_MODULE, KBUILD_MODNAME);
> +     __xenbus_register_frontend(drv, THIS_MODULE, KBUILD_MODNAME)

Oops.  Applied to stable/for-linus-4,0, thanks.

However, the preferred style for a caller would be:

ret = xenbus_register_frontend(...);
if (ret < 0) {
    ...

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel