Re: [Xen-devel] [RFC v1 6/8] xen: x86: make XEN_PV* stuff depend on PARAVIRT and PARAVIRT_CLOCK

["Luis R. Rodriguez" <mcgrof@xxxxxxxx>]

On Wed, Feb 25, 2015 at 03:45:56PM +0000, Stefano Stabellini wrote:
> On Wed, 11 Feb 2015, Luis R. Rodriguez wrote:
> > From: "Luis R. Rodriguez" <mcgrof@xxxxxxxx>
> > 
> > This will later more easily let us unfold PARAVIRT and PARAVIRT_CLOCK
> > from under CONFIG_XEN. All the XEN_PV* stuff is under the x86 universe.
> > This is as per the agreed upon Xen Kconfig changes [0].
> > 
> > [0] http://comments.gmane.org/gmane.comp.emulators.xen.devel/231579
> > 
> > Signed-off-by: Luis R. Rodriguez <mcgrof@xxxxxxxx>
> > ---
> >  arch/x86/xen/Kconfig | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig
> > index 9e0442f..50e2fb4 100644
> > --- a/arch/x86/xen/Kconfig
> > +++ b/arch/x86/xen/Kconfig
> > @@ -21,6 +21,8 @@ config XEN_DOM0
> >  
> >  config XEN_PVHVM
> >     def_bool y
> > +   select PARAVIRT
> > +   select PARAVIRT_CLOCK
> >     depends on XEN && PCI && X86_LOCAL_APIC
> >  
> >  config XEN_MAX_DOMAIN_MEMORY
> > @@ -49,11 +51,15 @@ config XEN_DEBUG_FS
> >  config XEN_PVH
> >     bool "Support for running as a PVH guest"
> >     depends on X86_64 && XEN
> > +   select PARAVIRT
> > +   select PARAVIRT_CLOCK
> >     select XEN_PVHVM
> >     def_bool n
> >  
> >  config XEN_PV
> >     bool "Support for running as a PV guest"
> >     depends on XEN && X86
> > +   select PARAVIRT
> > +   select PARAVIRT_CLOCK
> >     select XEN_HAVE_PVMMU
> >     def_bool n
> 
> Given that all select PARAVIRT and PARAVIRT_CLOCK, shouldn't we just
> move them under config XEN?

I believe this makes sense given that XEN_FRONTEND will now also
select it if we remove XEN_PVHVM and instead fold what it provides
under XEN_FRONTEND. I'll send a v4 kconfig changes as things look
so far.

  Luis

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel