Re: [Xen-devel] [PATCH v2 6/7] build system: stubdom targets now depends on mini-os target

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2015-02-20 at 11:17 +0000, Wei Liu wrote:
> @@ -161,7 +163,7 @@ clean-tools:
>       $(MAKE) -C tools clean
>  
>  .PHONY: clean-stubdom
> -clean-stubdom:
> +clean-stubdom: mini-os-dir
>       $(MAKE) -C stubdom crossclean
>  ifeq (x86_64,$(XEN_TARGET_ARCH))
>       XEN_TARGET_ARCH=x86_32 $(MAKE) -C stubdom crossclean
> @@ -187,11 +189,12 @@ distclean-tools:
>       $(MAKE) -C tools distclean
>  
>  .PHONY: distclean-stubdom
> -distclean-stubdom:
> +distclean-stubdom: mini-os-dir

These two are a bit odd, since they will force a clone in order to clean
(and in the distclean case immediately discard again).

The way we handle this with e.g. qemu is to have
subdir-clean-qemu-xen-traditional-dir:
        set -e; if test -d qemu-xen-traditional-dir/.; then \
                $(MAKE) -C qemu-xen-traditional-dir clean; \
        fi

so I think you want a pair of {clean,distclean}-mini-os-dir rules which
recurse iff the dir exists.

>       $(MAKE) -C stubdom distclean
>  ifeq (x86_64,$(XEN_TARGET_ARCH))
>       XEN_TARGET_ARCH=x86_32 $(MAKE) -C stubdom distclean
>  endif
> +     rm -rf extras/mini-os extras/mini-os-remote
>  
>  .PHONY: distclean-docs
>  distclean-docs:
> diff --git a/Makefile.mini-os b/Makefile.mini-os
> new file mode 100644
> index 0000000..46b1d80
> --- /dev/null
> +++ b/Makefile.mini-os

I still think this file doesn't contain enough to warrant being separate
to the main Makefile.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel